-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate radiobuttons.js and radio2.js logic #2203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, tested most of the links. I'll leave it to @gavrielm to test gene variant edit UI.
geneVariant UI works well. Thanks for the refactor. I noticed the spacing between radio options is noticeably larger compared to that on master. Is this desired? |
@gavrielm, Thanks for pointing that out. The styles were updated to use padding instead of margin. I missed this one. The newest commit fixes the issues you noted. |
@gavrielm, The styling for the time scale toggle removed the margin (in this case padding, set to 0) in master. The same styling removal wasn't repeated for the groupset radios. Do you want them to be the same? If so which one, no padding or the default 5px? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. geneVariant and cox outcome edit UIs look good.
Description
Changes:
Test, everywhere it's implemented:
3 Genes
-> Click on different radio buttons -> Appearance and functionality should be the same as prod.Checklist
Check each task that has been performed or verified to be not applicable.