Change read methods to yaml #58
Open
+184
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main config file uses yaml and contains all config from the previous 4 files.
This will allow the application to run on a local machine with production credentials. Acts as an alternative to using docker
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 96.32% 98.68% +2.36%
==========================================
Files 12 12
Lines 571 608 +37
==========================================
+ Hits 550 600 +50
+ Misses 21 8 -13 ☔ View full report in Codecov by Sentry. |
DavidFair
requested changes
Oct 18, 2024
| if not repos: | ||
| raise RepositoriesNotGiven("repos.csv does not contain any repositories.") | ||
| raise RepositoriesNotGiven("config.yml does not contain any repositories.") |
There was a problem hiding this comment.
We don't have any docs for how the config.yml should look in this PR? It requires someone to effectively dig the source code
There was a problem hiding this comment.
Those changes are in #57 once it is merged and this one rebased then it will make sense.
Since the config files have changed this version is no longer compatible with previous deployments
DavidFair
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are in accordance with the proposal from #57
Moving the application config to a yaml file means less configuration files overall and they are all in the same file type (not csv and json and txt).
Yaml is also more readable.