-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Closes #1558) support out-of-order parameter statements #2309
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2309 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 339 339
Lines 46054 46069 +15
=======================================
+ Hits 45985 46000 +15
Misses 69 69
☔ View full report in Codecov by Sentry. |
CI is happy. Have launched the integration tests... |
Integration tests are green too. Ready for review from either @sergisiso or @rupertford I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arporter This is a enhancement of fparserreader to support out-of-order parameters statements. The relevant code is unmodified but moved into a subroutine and triggered later. I agree with the movement. All tests, formatters, codecov and abscense of TODO and integration tests have passed. This is ready to merge, but I will wait for #2301 as it was marked ready first.
This PR simply moves the existing functionality for processing PARAMETER statements into a separate routine which can then be called once all the variable declarations have been processed.