Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #1558) support out-of-order parameter statements #2309

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

arporter
Copy link
Member

@arporter arporter commented Sep 12, 2023

This PR simply moves the existing functionality for processing PARAMETER statements into a separate routine which can then be called once all the variable declarations have been processed.

@arporter arporter added NEMO Issue relates to the NEMO domain PSyIR Core PSyIR functionality in progress labels Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f54db94) 99.85% compared to head (35ad0b9) 99.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2309   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         339      339           
  Lines       46054    46069   +15     
=======================================
+ Hits        45985    46000   +15     
  Misses         69       69           
Files Changed Coverage Δ
src/psyclone/psyir/frontend/fparser2.py 100.00% <100.00%> (ø)
...ts/psyir/frontend/fparser2_parameter_stmts_test.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arporter arporter temporarily deployed to integration September 12, 2023 15:02 — with GitHub Actions Inactive
@arporter
Copy link
Member Author

CI is happy. Have launched the integration tests...

@arporter
Copy link
Member Author

Integration tests are green too. Ready for review from either @sergisiso or @rupertford I think.

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter This is a enhancement of fparserreader to support out-of-order parameters statements. The relevant code is unmodified but moved into a subroutine and triggered later. I agree with the movement. All tests, formatters, codecov and abscense of TODO and integration tests have passed. This is ready to merge, but I will wait for #2301 as it was marked ready first.

@sergisiso sergisiso merged commit f408b3b into master Sep 14, 2023
11 checks passed
@sergisiso sergisiso deleted the 1558_param_ordering branch September 14, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEMO Issue relates to the NEMO domain PSyIR Core PSyIR functionality ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants