2091: renaming and moving DynKern to LFRicKern

[mo-lottieturner]

closes #2091

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34aac4a) 99.84% compared to head (eac784a) 99.85%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #2100    +/-   ##
========================================
  Coverage   99.84%   99.85%            
========================================
  Files         349      349            
  Lines       47376    47206   -170     
========================================
- Hits        47304    47138   -166     
+ Misses         72       68     -4     

Files	Coverage Δ
src/psyclone/domain/lfric/__init__.py	100.00% <100.00%> (ø)
src/psyclone/domain/lfric/algorithm/lfric_alg.py	100.00% <100.00%> (ø)
src/psyclone/domain/lfric/arg_ordering.py	100.00% <ø> (ø)
src/psyclone/domain/lfric/kern_call_arg_list.py	100.00% <ø> (ø)
...psyclone/domain/lfric/kern_call_invoke_arg_list.py	100.00% <ø> (ø)
src/psyclone/domain/lfric/kern_stub_arg_list.py	100.00% <ø> (ø)
src/psyclone/domain/lfric/kernel_interface.py	100.00% <ø> (ø)
src/psyclone/domain/lfric/lfric_collection.py	100.00% <100.00%> (ø)
src/psyclone/domain/lfric/lfric_kern.py	100.00% <100.00%> (ø)
...c/psyclone/domain/lfric/lfric_kern_call_factory.py	100.00% <100.00%> (ø)
... and 12 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TeranIvy]

Note: To be reviewed after #2090 is merged - this is the final PR to close #2091.

[TeranIvy]

#2095 is now merged to master. I'd suggest updating this branch with the master, resolving conflicts and tidying up imports. Please also check the changes for pycodestyle and pylint.

[mo-lottieturner]

@arporter I think I spoke too soon there! I think all of the obvious stuff is fixed, and the checks are running through to the pytest part now. The confusing bit is that I have two test failures, neither of which are in files that use DynKern/LFRicKern:

tests/dynamo0p3_multigrid_test.py: test_cont_field_restrict
tests/domain/lfric/transformations/dynamo0p3_transformations_test.py: test_colour_continuous_writer_intergrid

this is mostly for myself to track where i'm at but also wondering if you or @TeranIvy have any insight?

[arporter]

The second test failure looks as though the Schedule has changed and we are now attempting to apply a transformation to the wrong node. The best way to see what's going on is to do pytest --lf --pdb. Once in the debugger you can examine the Schedule to see its structure. Probably the test should be generalised to use a walk to find the right node. As for the first failing test, that looks like a simple text change. Again, if you use the --pdb option you can print out the code that is being generated and compare with what the test is expecting.

[mo-lottieturner]

@arporter Fixed! back to you for hopefully final review

[arporter]

Looking good now.
Just waiting on integration tests.

[arporter]

Hi @mo-lottieturner, I was going to make the minor changes myself but there are a few so I'm going to be good and ask you to do them (while the integration tests run). Then we can get this on.

There are also a couple of Comments from previous reviews that haven't been addressed.

[arporter]

Integration tests were all green :-)

[mo-lottieturner]

back to you @arporter

[arporter]

All requested changes have been made.
Ref. guide still builds fine.
Will proceed to merge.