Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PHP8.3 and lcobucci/jwt 5 #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update to PHP8.3 and lcobucci/jwt 5 #42

wants to merge 2 commits into from

Conversation

heiglandreas
Copy link

This PR provides changes to be able to use the library with PHP8.3 as well as with lcobucci/jwt 5.

The changes were rather small. It consists of 2 things:

  • Update to PHPUnit 10 to avoid the prophecy requirement that is stuck to PHP8.2. The changes required are mainly moving from instance data-providers to static data-providers along with some minor adaptions.
  • Update the code to use lcobucci/jwt 5. The only change necessary was to replace using the configuration object to parse the token. The simple way of creating a configuration object doesn ot work any more, so I instead created the parser that is used in the configurartions "parse" method and use that directly.

@heiglandreas
Move to PHPUnit 10
f049491 
THis prepares the whole testsuite to be usable with PHP8.3
@heiglandreas
Update JWT-lib to v5
88ea9f5 
THis allows to use the latest version of the JWT-lib. Some changes where
necessary due to the previous way not being supported anymore but as
that was anyhow only used to parse the token we can also use the default
way of parsing the token without needing a whole configuration object in
the first place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heiglandreas