RTLSDR IQ imbalance ???

.github/workflows/c-cpp.yml

@@ -0,0 +1,114 @@
+name: C/C++ CI
+
+on:
+  push:
+    branches: [ master, development ]
+  pull_request:
+    branches: [ master, development ]
+
+jobs:
+  build_ubuntu-amd64_latest:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: prerequisites
+    # pre-installed on ubuntu-1804: build-essential, git 2.28.0, cmake 3.10/3.17, make
+    # pre-installed: clang 6.0 / 8 / 9, gcc/++ 7.5.0/8.4.0/9.3.0
+      run: sudo apt -qq update && sudo apt -yqq install libusb-1.0-0-dev
+    - name: cmake_make
+      run: mkdir build && cmake -S . -B build && cd build && make
+    - name: compress
+      run: tar zcvf librtlsdr_build_ubuntu-amd64_latest.tar.gz --directory=build/src --exclude=CMakeFiles --exclude=*.cmake --exclude=Makefile --exclude=rtl_app_ver.h .
+    - name: 'Upload Artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: ubuntu_latest_build
+        path: librtlsdr_build_ubuntu-amd64_latest.tar.gz
+
+  build_macos_latest:
+    runs-on: macos-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    #- name: prerequisites
+    # pre-installed on macos-10.15: git 2.28.0, cmake 3.18.2, libusb 1.0.23
+    # pre-installed: clang/LLVM 10.0.1, gcc/++ 8.4.0/9.3.0
+    #  run: brew install libusb
+    - name: cmake_make
+      run: mkdir build && cmake -S . -B build && cd build && make
+    - name: compress
+      run: tar zcvf librtlsdr_build_macos-latest.tar.gz --directory=build/src --exclude=CMakeFiles --exclude=*.cmake --exclude=Makefile --exclude=rtl_app_ver.h .
+    - name: 'Upload Artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: macos_latest_build
+        path: librtlsdr_build_macos-latest.tar.gz
+
+  cross_build_win32_win64_latest:
+    runs-on: ubuntu-20.04
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: prerequisites
+      run: sudo apt -qq update && sudo apt -yqq install gcc-mingw-w64
+    - name: build_w32_static
+      run: bash ./cross_build_mingw32.sh static -DLINK_RTLTOOLS_AGAINST_STATIC_LIB=ON
+    - name: build_w32_static_udpsrv
+      run: bash ./cross_build_mingw32.sh static_udpsrv -DLINK_RTLTOOLS_AGAINST_STATIC_LIB=ON -DPROVIDE_UDP_SERVER=ON
+    - name: build_w32_dlldep
+      run: bash ./cross_build_mingw32.sh dlldep
+    - name: build_w32_dlldep_udpsrv
+      run: bash ./cross_build_mingw32.sh dlldep_udpsrv -DPROVIDE_UDP_SERVER=ON
+
+    - name: build_w64_static
+      run: bash ./cross_build_mingw64.sh static -DLINK_RTLTOOLS_AGAINST_STATIC_LIB=ON
+    - name: build_w64_static_udpsrv
+      run: bash ./cross_build_mingw64.sh static_udpsrv -DLINK_RTLTOOLS_AGAINST_STATIC_LIB=ON -DPROVIDE_UDP_SERVER=ON
+    - name: build_w64_dlldep
+      run: bash ./cross_build_mingw64.sh dlldep
+    - name: build_w64_dlldep_udpsrv
+      run: bash ./cross_build_mingw64.sh dlldep_udpsrv -DPROVIDE_UDP_SERVER=ON
+
+    - name: 'upload w32 static artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: rtlsdr-bin-w32_static
+        path: rtlsdr-bin-w32_static/bin/
+    - name: 'upload w32 static_udpsrv artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: rtlsdr-bin-w32_static_udpsrv
+        path: rtlsdr-bin-w32_static_udpsrv/bin/
+    - name: 'upload w32 dlldep artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: rtlsdr-bin-w32_dlldep
+        path: rtlsdr-bin-w32_dlldep/bin/
+    - name: 'upload w32 dlldep_udpsrv artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: rtlsdr-bin-w32_dlldep_udpsrv
+        path: rtlsdr-bin-w32_dlldep_udpsrv/bin/
+
+    - name: 'upload w64 static artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: rtlsdr-bin-w64_static
+        path: rtlsdr-bin-w64_static/bin/
+    - name: 'upload w64 static_udpsrv artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: rtlsdr-bin-w64_static_udpsrv
+        path: rtlsdr-bin-w64_static_udpsrv/bin/
+    - name: 'upload w64 dlldep artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: rtlsdr-bin-w64_dlldep
+        path: rtlsdr-bin-w64_dlldep/bin/
+    - name: 'upload w64 dlldep_udpsrv artifact'
+      uses: actions/upload-artifact@v2
+      with:
+        name: rtlsdr-bin-w64_dlldep_udpsrv
+        path: rtlsdr-bin-w64_dlldep_udpsrv/bin/
+

.gitignore

@@ -38,4 +38,19 @@ src/rtl_tcp
 CMakeCache.txt
 */CMakeFiles
 CMakeFiles
-*.cmake
+build
+
+**/*.o
+**/*.so*
+**/*.a
+src/rtl_adsb
+src/rtl_eeprom
+src/rtl_fm
+src/rtl_ir
+src/rtl_power
+src/rtl_rpcd
+src/rtl_test
+
+debianize/*.deb
+.cproject
+.project

CMakeLists.txt

@@ -21,28 +21,52 @@
 ########################################################################
 # Project setup
 ########################################################################
-cmake_minimum_required(VERSION 2.6)
+cmake_minimum_required(VERSION 2.6...3.19)
 project(rtlsdr C)
 
+# quite old cmake version - probably for compatibility with old OS versions?
+# see https://cmake.org/cmake/help/cmake2.6docs.html
+
+
 #select the release build type by default to get optimization flags
 if(NOT CMAKE_BUILD_TYPE)
    set(CMAKE_BUILD_TYPE "Release")
    message(STATUS "Build type not specified: defaulting to release.")
 endif(NOT CMAKE_BUILD_TYPE)
 set(CMAKE_BUILD_TYPE ${CMAKE_BUILD_TYPE} CACHE STRING "")
 
-list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake/Modules)
+list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake/Modules)
 
 if(NOT LIB_INSTALL_DIR)
    set(LIB_INSTALL_DIR lib)
 endif()
 
+OPTION(LINK_RTLTOOLS_AGAINST_STATIC_LIB "Link rtl-tools statically against librtlsdr" OFF)
+
+OPTION(PROVIDE_UDP_SERVER "Provide UDP server for tests" OFF)
+
+OPTION(WITH_RPC "RPC for non-Windows" OFF)
+
 # Set the version information here
 set(VERSION_INFO_MAJOR_VERSION 0) # increment major on api compatibility changes
-set(VERSION_INFO_MINOR_VERSION 6) # increment minor on feature-level changes
-set(VERSION_INFO_PATCH_VERSION 0) # increment patch for bug fixes and docs
+set(VERSION_INFO_MINOR_VERSION 9) # increment minor on feature-level changes
+set(VERSION_INFO_PATCH_VERSION git) # increment patch for bug fixes and docs
 include(Version) # setup version info
 
+########################################################################
+# Version defines to include in library and tools
+########################################################################
+
+configure_file(
+    ${CMAKE_CURRENT_SOURCE_DIR}/src/rtl_app_ver.h.in
+    ${CMAKE_CURRENT_BINARY_DIR}/src/rtl_app_ver.h
+    @ONLY )
+
+
+if(PROVIDE_UDP_SERVER)
+    add_definitions(-DWITH_UDP_SERVER)
+endif()
+
 ########################################################################
 # Compiler specific setup
 ########################################################################
@@ -59,12 +83,40 @@ elseif(MSVC14 OR MSVC14)
 #pthread-w32 issue, timespec is now part of time.h
     ADD_DEFINITIONS(-D_TIMESPEC_DEFINED)
 endif()
+if (APPLE)
+  set(CMAKE_MACOSX_RPATH ON)
+endif (APPLE)
+
+OPTION(RTL_STATIC_BUILD "Build rtl-tools static (except RTLSDR.DLL) on MinGW/Win32" ON)
+if(RTL_STATIC_BUILD)
+    if (WIN32)
+        if(MINGW)
+            # Special MINGW stuff here
+            # see https://cmake.org/pipermail/cmake/2012-September/051970.html
+            # see http://stackoverflow.com/questions/13768515/how-to-do-static-linking-of-libwinpthread-1-dll-in-mingw
+            set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -static-libgcc -static")
+            set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libgcc -static-libstdc++")
+            set(CMAKE_SHARED_LIBRARY_LINK_C_FLAGS "${CMAKE_SHARED_LIBRARY_LINK_C_FLAGS} -static-libgcc -s")
+            set(CMAKE_SHARED_LIBRARY_LINK_CXX_FLAGS "${CMAKE_SHARED_LIBRARY_LINK_CXX_FLAGS} -static-libgcc -static-libstdc++ -s")
+        endif()
+    endif()
+endif()
+
+
+#########################################################################
+# Bug Fix
+#########################################################################
+OPTION(NEED_PTHREADS_WORKARROUND "PThreads Workarround for timespec")
+IF (NEED_PTHREADS_WORKARROUND)
+    ADD_DEFINITIONS(-DNEED_PTHREADS_WORKARROUND)
+ENDIF()
 
 ########################################################################
 # Find build dependencies
 ########################################################################
 find_package(PkgConfig)
 find_package(LibUSB)
+cmake_policy(SET CMP0075 NEW)
 if(WIN32 AND NOT MINGW)
     set(THREADS_USE_PTHREADS_WIN32 true)
 endif()
@@ -80,8 +132,9 @@ endif()
 # Setup the include and linker paths
 ########################################################################
 include_directories(
-    ${CMAKE_SOURCE_DIR}/include
+    ${PROJECT_SOURCE_DIR}/include
     ${LIBUSB_INCLUDE_DIR}
+    ${CMAKE_CURRENT_BINARY_DIR}/src
     ${THREADS_PTHREADS_INCLUDE_DIR}
 )
 
@@ -95,14 +148,17 @@ include_directories(
 ########################################################################
 # Create uninstall target
 ########################################################################
-configure_file(
-    ${CMAKE_SOURCE_DIR}/cmake/cmake_uninstall.cmake.in
-    ${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake
-@ONLY)
+if(NOT TARGET uninstall)
+    configure_file(
+        ${PROJECT_SOURCE_DIR}/cmake/cmake_uninstall.cmake.in
+        ${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake
+        @ONLY
+    )
 
-add_custom_target(uninstall
-    ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake
-)
+    add_custom_target(uninstall
+        ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_BINARY_DIR}/cmake_uninstall.cmake
+    )
+endif()
 
 ########################################################################
 # Install udev rules

README.md

@@ -0,0 +1,113 @@
+[![librtlsdr version](https://img.shields.io/github/tag/librtlsdr/librtlsdr.svg?style=flat&label=librtlsdr)](https://github.com/librtlsdr/librtlsdr/releases)
+[![GPLv2 License](http://img.shields.io/badge/license-GPLv2-brightgreen.svg)](https://tldrlegal.com/license/gnu-general-public-license-v2)
+
+# Description
+
+rtl-sdr turns your Realtek RTL2832 based DVB dongle into a SDR receiver
+
+
+# New enhancements and features in this version
+
+Many different developments have been taken in this release. For an overview, see [improvements](README_improvements.md)
+
+# Build / Install (on debian/ubuntu)
+
+## prerequisites
+development tools have to be installed:
+```
+sudo apt-get install build-essential cmake git
+```
+
+install the libusb-1.0 development package::
+```
+sudo apt-get install libusb-dev libusb-1.0-0-dev
+```
+
+## retrieve the sources - right branch
+
+```
+git clone https://github.com/librtlsdr/librtlsdr.git
+```
+
+in case you want the *development* branch, e.g. for testing or preparing patches:
+```
+cd librtlsdr
+git checkout development
+```
+
+by default, you should have the *master* branch, in doubt:
+```
+cd librtlsdr
+git status
+git checkout master
+```
+
+## build
+run cmake and start compilation. cmake will accept some options, e.g.
+* `-DINSTALL_UDEV_RULES=ON`, default is `OFF`
+* `-DDETACH_KERNEL_DRIVER=ON`, default is `OFF`
+* `-DPROVIDE_UDP_SERVER=ON`, default is `OFF`
+* `-DWITH_RPC=ON`, default is `OFF`
+* `-DLINK_RTLTOOLS_AGAINST_STATIC_LIB=ON`, default is `OFF`
+* `-DRTL_STATIC_BUILD=OFF`, default is `ON`: for MINGW on WIN32
+
+all cmake options are optional
+
+```
+mkdir build && cd build
+cmake ../ -DINSTALL_UDEV_RULES=ON
+make
+```
+
+## install
+setup into prefix, usually will require `sudo`:
+```
+sudo make install
+sudo ldconfig
+```
+
+# Development builds / binaries
+
+[GitHub Actions](https://github.com/librtlsdr/librtlsdr/actions) is used for development builds - for Linux (x86), MacOS and Windows x86 32/64.
+Cross-builds for Windows from a Linux machine: see [cross_build_mingw32.sh](cross_build_mingw32.sh) or [cross_build_mingw64.sh](cross_build_mingw64.sh)
+
+# For more information see:
+
+http://superkuh.com/rtlsdr.html
+
+https://osmocom.org/projects/rtl-sdr/wiki/Rtl-sdr
+
+
+# Setup for SDR only use - without DVB compatibility:
+
+- a special USB vendor/product id got reserved at http://pid.codes/ : 0x1209/0x2832
+- for such devices the linux kernel's DVB modules are not loaded automatically,
+ thus can be used without blacklisting *dvb_usb_rtl28xxu* below /etc/modprobe.d/
+- this allows to use a second RTL dongle for use with DVB in parallel
+- the IDs can be programmed with '`rtl_eeprom -n`' or '`rtl_eeprom -g realtek_sdr`'
+- for permanent blacklisting you might check/call following from the clone git directory
+    ```./install-blacklist.sh```
+
+
+# Contributing
+
+Pull requests are always welcome but please make changes to, and pull request from, the development branch.
+
+## Initial setup:
+
+- fork the librtlsdr repo via GitHub
+- clone your fork locally and cd to the cloned repo's folder
+- add the upstream development repo:
+    * `git remote add upstream [email protected]:librtlsdr/librtlsdr.git`
+- track the development branch: 
+    * `git branch --track development origin/development`
+
+## Normal workflow:
+
+- checkout the development branch and make your changes
+- commit your changes
+- sync your local development branch with the upstream development branch:
+    * `git fetch upstream`
+    * `git merge upstream/development`
+- push your commit/s to your forked repo
+- do a pull request via GitHub