Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work around context loss with async-listener #21

Merged
merged 1 commit into from
Jun 21, 2017
Merged

work around context loss with async-listener #21

merged 1 commit into from
Jun 21, 2017

Commits on Jun 21, 2017

  1. work around context loss with async-listener 

    [async-listener][1] is important module for APM tools and for long
stack traces. Promises make the concept of a long-stack-trace ambiguous
– as you can conceive the `then` callback as a continuation of either
the resolution context or the context that queued the `then`
callback ([more details][2]).

async-listener defaults to the resolution context. This is the wrong
default for how we are using promises here, resuling in APM tools
like Stackdriver Trace losing context.

We work-around the problem by not using the promise after it has
resolved.

[1]: https://www.npmjs.com/package/async-listener
[2]: othiym23/node-continuation-local-storage#64
    @ofrobots
    ofrobots committed Jun 21, 2017
    Configuration menu
    Copy the full SHA
    3087093 View commit details
    Browse the repository at this point in the history