-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate schemars derives in Rust generator #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Copied from 66a4913f1bd0de167ff50edd05c93dd958bec0eb Copied from stellar/rs-stellar-xdr#349 Co-authored-by: Willem Wyndham <[email protected]>
This was referenced Mar 26, 2024
leighmcculloch
commented
May 15, 2024
sisuresh
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Generate
schemars::JsonSchema
derives in Rust generator whenever the existingserde
feature is enabled.Why
To support generating JSON schemas of the JSON that gets generated for the types.
Close stellar/rs-stellar-xdr#348
Todo
Adopt @willemneal's no additional properties from feat: add wasm-pack to allow publishing to npm rs-stellar-xdr#351 (comment)(Edit: Reduces size, but results in same affect, so leaving out and we can add as an improvement.)Include comments from .x files(Edit: We can do this as a follow up.)Add json schema meta titles for union arms. (like how @willemneal did in a visitor, but add them in the original schema for the type in the generated code)(Edit: Deferred.)Related