Rust: Limit preallocation during byte (opaque, string) reads to 1kb #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
Oct 28, 2023
Comment on lines
+6
to
+7
| #[cfg(feature = "std")] | ||
| const MAX_PREALLOCATED_BYTES_READ: usize = 1024; // 1KB |
There was a problem hiding this comment.
Would be nice to make this configurable. But would rather set it to a sensible limit at this point and revisit that when it matters.
graydon
requested changes
Oct 30, 2023
dmkozh
reviewed
Oct 30, 2023
Merged
|
Alternative implementation that I believe solves the same problem is proposed in #179. |
|
Closing in favor of #179. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In the Rust generated code limit preallocation during byte (opaque, string) reads to 1kb.
Why
Close #174