Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocate memory for vararray as needed in Rust #173

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Allocate memory for vararray as needed in Rust #173

merged 3 commits into from
Oct 21, 2023

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 20, 2023 •
edited
Loading

What

Allocate memory for vararray as needed in Rust generated code.

Why

Close #174

@jayz22
Copy link
Contributor

jayz22 commented Oct 20, 2023

There are more places to fix. For example, some calling vec![0; len] https://github.com/stellar/xdrgen/blob/master/lib/xdrgen/generators/rust/src/types.rs#L1222

@leighmcculloch leighmcculloch marked this pull request as ready for review October 20, 2023 23:51
@graydon graydon self-requested a review October 21, 2023 00:37
@graydon graydon merged commit b405294 into master Oct 21, 2023
3 checks passed
@graydon graydon deleted the withcapnew branch October 21, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graydon graydon graydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust: Remove preallocation in vararray / varopaque conversions
3 participants
@leighmcculloch @jayz22 @graydon