Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(java): Remove the dependency on third-party libraries. #168

Merged

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Sep 11, 2023

Now, we relied on Guava. I think this is unnecessary. Let's remove it and use alternatives in the standard library.

@overcat
Copy link
Contributor Author

overcat commented Sep 11, 2023

Hi @sreuland, can you review this PR?

@sreuland
Copy link

sure, this pr is large, can you provide some guidance on where to start or drill down from, etc to understand the change for context?

@overcat
Copy link
Contributor Author

overcat commented Sep 12, 2023

This PR is actually not that big, it looks big because most of the changes are generated code from testing. We mainly need to focus on the changes in the lib/xdrgen/generators folder, where the dependency on guava has been removed.

@overcat
Copy link
Contributor Author

overcat commented Sep 12, 2023

Based on this PR, we can generate the changes required for lightsail-network/java-stellar-sdk#525.

@sreuland
Copy link

This PR is actually not that big, it looks big because most of the changes are generated code from testing. We mainly need to focus on the changes in the lib/xdrgen/generators folder, where the dependency on guava has been removed.

ok, that helps, looks good. Are there tests locally in this repo to confirm the generated java code is compiling, no additional warnings/errors?

@overcat
Copy link
Contributor Author

overcat commented Sep 12, 2023

This PR is actually not that big, it looks big because most of the changes are generated code from testing. We mainly need to focus on the changes in the lib/xdrgen/generators folder, where the dependency on guava has been removed.

ok, that helps, looks good. Are there tests locally in this repo to confirm the generated java code is compiling, no additional warnings/errors?

Are there tests locally in this repo to confirm the generated java code is compiling, no additional warnings/errors?

There is currently no such test.

@overcat
Copy link
Contributor Author

overcat commented Sep 12, 2023

The code generated by this PR has been applied to lightsail-network/java-stellar-sdk#525, and the CI is already green.

If we want to verify whether the Java code in this repo can be compiled, let's create a new issue to discuss how to add it.

@sreuland
Copy link

The code generated by this PR has been applied to stellar/java-stellar-sdk#525, and the CI is already green.

If we want to verify whether the Java code in this repo can be compiled, let's create a new issue to discuss how to add it.

ok, that could be a follow-on ticket to capture tech debt type. This pr is ready to merge correct?

@overcat
Copy link
Contributor Author

overcat commented Sep 12, 2023

The code generated by this PR has been applied to stellar/java-stellar-sdk#525, and the CI is already green.
If we want to verify whether the Java code in this repo can be compiled, let's create a new issue to discuss how to add it.

ok, that could be a follow-on ticket to capture tech debt type. This pr is ready to merge correct?

Yes, it's ready.

@sreuland sreuland merged commit f0c4145 into stellar:master Sep 12, 2023
3 checks passed
@overcat overcat deleted the java-remove-third-party-dependencies branch November 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants