Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert live entries to init entries in lowest level of bucketlist #4492

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Convert live entries to init entries in lowest level of bucketlist #4492

wants to merge 5 commits into from

Conversation

ThomasBrady
Copy link
Contributor

@ThomasBrady ThomasBrady commented Oct 1, 2024 •
edited
Loading

Fixing failing test, can hold off on review for now

Description

Resolves #193

Changes BucketOutputIterator::put to convert LIVEENTRY to INITENTRY if mKeepDeadEntries == true.

Perhaps this variable should be renamed to mIsLowestLevel or something now that it affects dead entry persistence and init entry to live entry conversion.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@ThomasBrady ThomasBrady requested review from SirTyson and removed request for SirTyson October 1, 2024 20:56
@ThomasBrady ThomasBrady changed the title Convert live entries to init entries in lowest level of bucketlist WIP: Convert live entries to init entries in lowest level of bucketlist Oct 1, 2024
@ThomasBrady ThomasBrady changed the title WIP: Convert live entries to init entries in lowest level of bucketlist Convert live entries to init entries in lowest level of bucketlist Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirTyson SirTyson Awaiting requested review from SirTyson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ThomasBrady