Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nomination prototype #3856

Closed
wants to merge 54 commits into from
Closed

Nomination prototype #3856

wants to merge 54 commits into from

Commits on Sep 26, 2023

  1. SCP change 

    Update the TransactionSet fetching
    @JuI3s
    Hidenori Shinohara authored and JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    83c46a8 View commit details
    Browse the repository at this point in the history

  2. move mPendingTxRequests to private variable in implementation

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4c11fd0 View commit details
    Browse the repository at this point in the history

  3. fix clang format

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    e29bb86 View commit details
    Browse the repository at this point in the history

  4. Debugging tx fetching

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    5ac20c0 View commit details
    Browse the repository at this point in the history

  5. Debug tx queue source account limit test

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0e6cf73 View commit details
    Browse the repository at this point in the history

  6. Node adds pending tx set requests for missing tx sets

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    3478fba View commit details
    Browse the repository at this point in the history

  7. Remove debug info

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    5883118 View commit details
    Browse the repository at this point in the history

  8. Remove debug CLOG_INFO

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    da136a7 View commit details
    Browse the repository at this point in the history

  9. Make SEND_DONT_HAVE_DELAY configurable

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    541f632 View commit details
    Browse the repository at this point in the history

  10. Wait before sending DONT_HAVE for tx set hash request

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1db7bc2 View commit details
    Browse the repository at this point in the history

  11. Set default SEND_DONT_HAVE_DELAY to 2 seconds

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    46236b5 View commit details
    Browse the repository at this point in the history

  12. Set SEND_DONT_HAVE_DELAY to 100 milliseconds

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    cee418e View commit details
    Browse the repository at this point in the history

  13. Add delay sending DONT_HAVE test

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b8222e2 View commit details
    Browse the repository at this point in the history

  14. Change MS_TO_WAIT_FOR_FETCH_REPLY to constexpr

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    efee75d View commit details
    Browse the repository at this point in the history

  15. Limit number of outstanding pending getTxnSet requests

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4d5c13d View commit details
    Browse the repository at this point in the history

  16. Add recvGetTxSet flow diagram and set max num pending requests to 1

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    96b12f7 View commit details
    Browse the repository at this point in the history

  17. temp

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    e10a556 View commit details
    Browse the repository at this point in the history

  18. Add flow diagram for Peer::recvGetTxSet. 

    Add delay sending DONT_HAVE test.
    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c6757f4 View commit details
    Browse the repository at this point in the history

  19. Peers receive nomination envelops in "delay sending DONT_HAVE" test b… 

    …efore receiving tx sets, so these tx sets are not discarded. Eventually the peer sending the getTxSet request gets the tx set.
    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    5ff851a View commit details
    Browse the repository at this point in the history

  20. Fix typos and update documentation

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b85bc45 View commit details
    Browse the repository at this point in the history

  21. Herder purges pending getTxSet requests when value externalized

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f904642 View commit details
    Browse the repository at this point in the history

  22. Rename OverlayManager::getPendingGetTxSetRequests

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    3cbb29f View commit details
    Browse the repository at this point in the history

  23. Fix format

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    13c4874 View commit details
    Browse the repository at this point in the history

  24. Store pending getTxSet requests by slotIndex. Purge pending getTxSet … 

    …requests with stale slot indexes when new value externalized

Fix bug inserting weak ptr to set
    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1d69e90 View commit details
    Browse the repository at this point in the history

  25. Fix delay send DONT_HAVE test

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d8e0005 View commit details
    Browse the repository at this point in the history

  26. Change slot index in Peer::recvGetTxSet to currently tracked ledger seq

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b94fa8b View commit details
    Browse the repository at this point in the history

  27. Remove max number of pending getTxSet requests to keep

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    63303c2 View commit details
    Browse the repository at this point in the history

  28. Use slot index in recvGetTxSet from the highest slot index seen for t… 

    …x set
    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d8e25a6 View commit details
    Browse the repository at this point in the history

  29. Change require conditions in Herder test 'delay sending DONT_HAVE'

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    aaeba33 View commit details
    Browse the repository at this point in the history

  30. remove DONT_HAVE tests

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    92435b9 View commit details
    Browse the repository at this point in the history

  31. Add delay sending DONT_HAVE test

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f6d58c0 View commit details
    Browse the repository at this point in the history

  32. Test to make sure node rejects unknown getTxSet requests

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    41308d3 View commit details
    Browse the repository at this point in the history

  33. Delete delay sending DONT_HAVE simulation test

    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4d67a45 View commit details
    Browse the repository at this point in the history

  34. Do not start fetching when receive nomination msg with tx set hash fo… 

    …r an existing tx set
    @JuI3s
    JuI3s committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    ce080d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Quick fix for making delay sending DONT_HAVE test pass using legacy t… 

    …x sets
    @JuI3s
    JuI3s committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    99a9a63 View commit details
    Browse the repository at this point in the history

  2. Add assert(!forceIsNotGeneralized) to make sure it's only used for te… 

    …sting.
    @JuI3s
    JuI3s committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    ba04c15 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. PR fix No.1 

    PR fix No.1
    @JuI3s
    JuI3s committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9f534db View commit details
    Browse the repository at this point in the history

  2. fix pr 2

    @JuI3s
    JuI3s committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2acba40 View commit details
    Browse the repository at this point in the history

  3. PR fix 3

    @JuI3s
    JuI3s committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1651120 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. PR fix 3. Use generalized tx sets instead of tx sets.

    @JuI3s
    JuI3s committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    5e43b7a View commit details
    Browse the repository at this point in the history

  2. Working on generating load for test 'overlay tx set fetching test'

    @JuI3s
    JuI3s committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    1d71931 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Do not send tx set back to peers we've previously sent DONT_HAVE to

    @JuI3s
    JuI3s committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    254fc6f View commit details
    Browse the repository at this point in the history

  2. fix delay sending DONT_HAVE test

    @JuI3s
    JuI3s committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    5e5445d View commit details
    Browse the repository at this point in the history

  3. Send DONT_HAVE back immediately for slot index not currently tracking

    @JuI3s
    JuI3s committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    555b9e0 View commit details
    Browse the repository at this point in the history

  4. Update recvGetTxSet diagram

    @JuI3s
    JuI3s committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    86cd20b View commit details
    Browse the repository at this point in the history

  5. Change add recvGetTxSet clearing request logic and add documentation

    @JuI3s
    JuI3s committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    da29888 View commit details
    Browse the repository at this point in the history

  6. Reject untracked tx set message in recvGetTxSet

    @JuI3s
    JuI3s committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    a94237d View commit details
    Browse the repository at this point in the history

  7. temp

    @JuI3s
    JuI3s committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    fe80739 View commit details
    Browse the repository at this point in the history

  8. Revert "Change add recvGetTxSet clearing request logic and add docume… 

    …ntation"

This reverts commit da29888.
    @JuI3s
    JuI3s committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    cf90561 View commit details
    Browse the repository at this point in the history

  9. Fix ambiguities in and errors recvGetTxSet flow diagram

    @JuI3s
    JuI3s committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    5da884e View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Moving delay sending DONT_HAVE logic to Peer::maybeSendDontHave 

    Fix format
    @JuI3s
    JuI3s committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    101e0ae View commit details
    Browse the repository at this point in the history

  2. Fix bugs in maybeSendDontHaveAfterDelay

    @JuI3s
    JuI3s committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    73dba79 View commit details
    Browse the repository at this point in the history

  3. Turn log info msg for sending DONT_HAVE to trace

    @JuI3s
    JuI3s committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    a7ca10e View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Remove logs

    @JuI3s
    JuI3s committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    122363e View commit details
    Browse the repository at this point in the history