Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max_entry_expiration #3849

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Set max_entry_expiration #3849

merged 1 commit into from
Jul 22, 2023

Conversation

sisuresh
Copy link
Contributor

Description

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh requested a review from dmkozh July 21, 2023 22:13
@@ -76,6 +76,8 @@ getLedgerInfo(AbstractLedgerTxn& ltx, Config const& cfg,
sorobanConfig.stateExpirationSettings().minPersistentEntryExpiration;
info.min_temp_entry_expiration =
sorobanConfig.stateExpirationSettings().minTempEntryExpiration;
info.max_entry_expiration =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also initialize info ({})

@dmkozh
Copy link
Contributor

dmkozh commented Jul 21, 2023

r+ 3087441

@latobarita latobarita merged commit c2e1ab1 into stellar:master Jul 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants