Easier to capture scp messages #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuI3s
force-pushed
the
capture-scp-messages
branch
from
098b6f0
to
dd73764
Compare
JuI3s
force-pushed
the
capture-scp-messages
branch
2 times, most recently
from
8680e45
to
dd73764
Compare
|
MonsieurNicolas
requested changes
Jul 19, 2023
JuI3s
force-pushed
the
capture-scp-messages
branch
3 times, most recently
from
7462440
to
baf5229
Compare
marta-lokhova
requested changes
Jul 20, 2023
JuI3s
force-pushed
the
capture-scp-messages
branch
11 times, most recently
from
0245389
to
2c93596
Compare
JuI3s
force-pushed
the
capture-scp-messages
branch
from
2c93596
to
dd5b7f6
Compare
marta-lokhova
approved these changes
Aug 8, 2023
src/main/Config.cpp
Outdated
| @@ -142,6 +142,7 @@ Config::Config() : NODE_SEED(SecretKey::random()) | |||
| EXPERIMENTAL_BUCKETLIST_DB_INDEX_PAGE_SIZE_EXPONENT = 14; // 2^14 == 16 kb | |||
| EXPERIMENTAL_BUCKETLIST_DB_INDEX_CUTOFF = 20; // 20 mb | |||
| EXPERIMENTAL_BUCKETLIST_DB_PERSIST_INDEX = true; | |||
| PUBLISH_TO_ARCHIVE_DELAY = std::chrono::seconds{2}; | |||
There was a problem hiding this comment.
actually, should we set this to 0 by default, and operators that need this functionality can adjust the config manually?
src/history/HistoryManagerImpl.cpp
Outdated
|
|
||
| auto time = app.getClock().now(); | ||
| auto dur = time - start; | ||
| return std::chrono::duration_cast<std::chrono::seconds>(dur) > |
There was a problem hiding this comment.
>=? This way you don't need to special case std::chrono::seconds::zero
JuI3s
force-pushed
the
capture-scp-messages
branch
from
dd5b7f6
to
9a75ca1
Compare
capture scp messages draft remove extra white space clean up header impl moved delay publish logic to ledger manager rm delay timer from herder impl and add delay-publish-to-archive criterion add delay publish to archive config option preliminary changes for delay publish to archive logic in history manager impl Remove delay publish to archive logic from herder and ledger manager. Change delay-publish-to-archive work to ConditionalWork. update xdr make publish to archive delay configurable fix format fix format and work naming Make default publish-to-archive delay to 0
JuI3s
force-pushed
the
capture-scp-messages
branch
from
9a75ca1
to
419329c
Compare
marta-lokhova
approved these changes
Aug 11, 2023
|
r+ 419329c |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft working on #3769
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)