Bucketlist size meta #3807
Merged
Bucketlist size meta #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
force-pushed
the
bucketlist-size-meta
branch
from
7e78790
to
f9ed0f4
Compare
dmkozh
reviewed
Jul 5, 2023
src/bucket/BucketManager.h
Outdated
| #endif | ||
|
|
||
| // If currLedger is a ledger when we should snapshot, add a new snapshot to | ||
| // the sliding window and write it to disk |
There was a problem hiding this comment.
nit: Please add '.' in the end of comments
SirTyson
force-pushed
the
bucketlist-size-meta
branch
from
b38015a
to
b09481f
Compare
dmkozh
reviewed
Jul 6, 2023
| // update the window. If newSize < currSize, pop entries off window. If | ||
| // newSize > currSize, add as many copies of the current BucketList size to | ||
| // window until it has newSize entries. | ||
| void maybeUpdateBucketListWindowSize(AbstractLedgerTxn& ltx, |
There was a problem hiding this comment.
I think this should be a static/free function and not fields should be mutable. Instead, this would just update the ledger entry and then we will automatically update the fields as a part of SorobanNetworkConfig::loadFromLedger (it happens after any update).
I think it's not necessary to do the change in this PR though - probably just open an issue to do cleanup?
SirTyson
force-pushed
the
bucketlist-size-meta
branch
from
b09481f
to
9219a44
Compare
|
r+ 9219a44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3783
This PR emits
totalByteSizeOfBucketListin ledger close meta so that downstream systems can properly calculate Soroban storage related fees. This value is the 30 day average of the size of the BucketList calculated via daily snapshots. These snapshots are stored on disk in a sliding window viaCONFIG_ENTRY.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)