Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor issue in BallotProtocol.h comments #3788

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

JuI3s
Copy link
Contributor

@JuI3s JuI3s commented Jun 21, 2023

Description

The comment documentation for the BallotProtocol seems to refer to Slot.

/**
 * The Slot object is in charge of maintaining the state of the SCP protocol
 * for a given slot index.
 */
class BallotProtocol
{
...
}

/**
 * The Slot object is in charge of maintaining the state of the SCP protocol
 * for a given slot index.
 */
class Slot : public std::enable_shared_from_this<Slot>
{
...
}

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@mbsdf
Copy link

mbsdf commented Jun 30, 2023

@JuI3s last commit is not related to this PR, can you remove it and only keep the BallotProtocl.h change.

@JuI3s
Copy link
Contributor Author

JuI3s commented Jul 1, 2023

@JuI3s last commit is not related to this PR, can you remove it and only keep the BallotProtocl.h change.

Fixed it!

@mbsdf
Copy link

mbsdf commented Jul 6, 2023

r+ c9e50b9

@MonsieurNicolas
Copy link
Contributor

r+ c9e50b9

@latobarita latobarita merged commit 863e104 into stellar:master Jul 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants