Bugfix: make partial checkpoint files during DB migration, fix bug in…

… catchup that doesn't catch this
stellar · Oct 15, 2024 · 11544d9 · 11544d9
1 parent 63140a6
commit 11544d9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/catchup/VerifyLedgerChainWork.cpp b/src/catchup/VerifyLedgerChainWork.cpp
@@ -185,6 +185,8 @@ VerifyLedgerChainWork::verifyHistoryOfSingleCheckpoint()
     CLOG_DEBUG(History, "Verifying ledger headers from {} for checkpoint {}",
                ft.localPath_nogz(), mCurrCheckpoint);
 
+    auto const& hm = mApp.getHistoryManager();
+
     while (hdrIn)
     {
         try
@@ -243,6 +245,15 @@ VerifyLedgerChainWork::verifyHistoryOfSingleCheckpoint()
 
         if (beginCheckpoint)
         {
+            if (!hm.isFirstLedgerInCheckpoint(curr.header.ledgerSeq))
+            {
+                CLOG_ERROR(
+                    History, "Checkpoint did not start with {} - got {}",
+                    hm.firstLedgerInCheckpointContaining(curr.header.ledgerSeq),
+                    curr.header.ledgerSeq);
+                return HistoryManager::VERIFY_STATUS_ERR_MISSING_ENTRIES;
+            }
+
             // At the beginning of checkpoint, we can't verify the link with
             // previous ledger, so at least verify that header content hashes to
             // correct value

diff --git a/src/history/HistoryManagerImpl.cpp b/src/history/HistoryManagerImpl.cpp
@@ -159,6 +159,9 @@ HistoryManagerImpl::dropSQLBasedPublish()
         populateCheckpointFilesFromDB(mApp, mApp.getDatabase().getSession(),
                                       firstLedgerInCheckpointContaining(lcl),
                                       freq, *mCheckpoint);
+        LedgerHeaderUtils::copyToStream(
+            mApp.getDatabase(), mApp.getDatabase().getSession(),
+            firstLedgerInCheckpointContaining(lcl), freq, *mCheckpoint);
     }
     mApp.getDatabase().clearPreparedStatementCache();