Adapt to ResourceLimiter, replacing mem_fuel metering #950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #896
This is attempt 2. Follows up on #946 (review)
Make the host a
ResourceLimiter
, such that the entire memory budget is available to the Vm linear memory.Also hardcodes several other limits as
WASMI_LIMITS_CONFIG
, hopefully we won't need to change them ever.This is a superior approach to #946, both in terms of functional (dynamic memory limit) and cleanness (does not require changing the StoreData).
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]