Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dalek crates, k256, and wasmi for protocol 22 #1466

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Update dalek crates, k256, and wasmi for protocol 22 #1466

merged 2 commits into from
Sep 24, 2024

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Sep 23, 2024

Just update deps for p22

fix #1353
fix #1313

@graydon graydon requested review from sisuresh, dmkozh and a team as code owners September 23, 2024 23:49
@anupsdf
Copy link
Contributor

anupsdf commented Sep 23, 2024

Should we remove dalek from deny.toml? @dmkozh might have context on temporarily having there.

@anupsdf anupsdf added this pull request to the merge queue Sep 24, 2024
Merged via the queue into stellar:main with commit 1647571 Sep 24, 2024
12 checks passed
@anupsdf
Copy link
Contributor

anupsdf commented Sep 24, 2024 •
edited
Loading

Should we pin dalek to a specific version of 4.1.3 instead of >=4.1.3 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupsdf anupsdf anupsdf approved these changes

@sisuresh sisuresh Awaiting requested review from sisuresh sisuresh is a code owner

@dmkozh dmkozh Awaiting requested review from dmkozh dmkozh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@graydon @anupsdf