Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdr: Sanity-check allocations when decoding #5116

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Nov 15, 2023

@2opremio 2opremio changed the title xdr: Enforce maximum decoding allocation size xdr: Support maximum decoding allocation size Nov 15, 2023
@2opremio 2opremio changed the title xdr: Support maximum decoding allocation size xdr: Support providing a maximum decoding allocation size Nov 15, 2023
xdr/main.go Outdated Show resolved Hide resolved
@2opremio 2opremio marked this pull request as ready for review November 20, 2023 15:18
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@2opremio 2opremio changed the title xdr: Support providing a maximum decoding allocation size xdr: Sanity-check allocations when decoding Nov 22, 2023
@2opremio 2opremio merged commit 1924ea7 into release-horizon-v2.27.0 Nov 23, 2023
35 of 36 checks passed
@2opremio 2opremio deleted the xdr-max-alloc-size branch November 23, 2023 16:33
2opremio added a commit to stellar/stellar-cli that referenced this pull request Nov 23, 2023
This reverts commit 1ee4113
and updates stellar/go to stellar/go#5116
2opremio added a commit to 2opremio/soroban-cli that referenced this pull request Nov 23, 2023
This reverts commit 1ee4113
and updates stellar/go to stellar/go#5116
2opremio added a commit to stellar/stellar-cli that referenced this pull request Nov 25, 2023
This reverts commit 1ee4113
and updates stellar/go to stellar/go#5116
tamirms pushed a commit to tamirms/go that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants