Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST: getBlockRewards() and getSyncCommitteeRewards() implementation #6556

Merged
merged 11 commits into from
Sep 18, 2024
Merged

REST: getBlockRewards() and getSyncCommitteeRewards() implementation #6556

merged 11 commits into from
Sep 18, 2024

Conversation

cheatfate
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Unit Test Results

         9 files  ±0    1 355 suites  ±0   54m 33s ⏱️ +45s
  5 147 tests ±0    4 799 ✔️ ±0  348 💤 ±0  0 ❌ ±0 
21 510 runs  ±0  21 106 ✔️ ±0  404 💤 ±0  0 ❌ ±0 

Results for commit 23e6d3b. ± Comparison against base commit 1cc3c59.

♻️ This comment has been updated with latest results.

@tersec
Copy link
Contributor

tersec commented Sep 18, 2024

https://github.com/status-im/nimbus-eth2/blob/unstable/ncli/resttest-rules.json?

tersec
tersec reviewed Sep 18, 2024
View reviewed changes
beacon_chain/rpc/rest_rewards_api.nim Outdated
return RestApiResponse.jsonError(Http400, InvalidBlockIdValueError,
$error)

if (bident.kind == BlockQueryKind.Named) and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone specifies the genesis block in some other way than literally naming it genesis, the same logic should apply.

Copy link
Contributor Author

@cheatfate cheatfate Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b216cba and 23e6d3b

tersec
tersec reviewed Sep 18, 2024
View reviewed changes
beacon_chain/rpc/rest_rewards_api.nim Outdated

targetBlock =
withBlck(bdata):
if (bident.kind == BlockQueryKind.Named) and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone specifies the genesis block in some other way than literally naming it genesis, the same logic should apply.

Copy link
Contributor Author

@cheatfate cheatfate Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b216cba and 23e6d3b

@cheatfate
Copy link
Contributor Author

https://github.com/status-im/nimbus-eth2/blob/unstable/ncli/resttest-rules.json?

Added in 23e6d3b

@cheatfate cheatfate closed this Sep 18, 2024
@cheatfate cheatfate reopened this Sep 18, 2024
@tersec tersec merged commit e3fcd8b into unstable Sep 18, 2024
13 of 17 checks passed
@tersec tersec deleted the rewards-api branch September 18, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tersec tersec tersec left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheatfate @tersec