Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene player fixes and improvements #5340

Merged

Conversation

WithoutPants
Copy link
Collaborator

Various scene player fixes and improvements:

  • suppress logging of context cancelled errors during live transcode
  • if scrubbing (ie mouse button is down while dragging the scrubber), then don't play the video. Makes this behaviour consistent with direct streaming
  • debounce the source loading code during live transcoding. This means that fewer ffmpeg processes should be spawned while dragging across the scrubber
  • video will now play from the position clicked on the scrubber instead of from the start/resume time when clicking the scrubber before the video is started

@WithoutPants WithoutPants added the bug Something isn't working label Oct 4, 2024
@WithoutPants WithoutPants merged commit 4697271 into stashapp:develop Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant