Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding In Tagger Buttons #5158

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Gykes
Copy link
Contributor

@Gykes Gykes commented Aug 22, 2024

Adding in Search all and Create all buttons to tagger view.

So far this will add a Search All button, and then if any scenes have been found, generate a create all button. Once you are comfortable that all scenes are matched correctly you can click "create all" and it will create all performers and studios for you.

This is currently a WIP, the core functionality is there, but the CSS is a smidge wonky. I will also be adding in a "Save ID" button which will click the save StashID button so that any performers and scenes can get an associated StashID. This takes some very well used userscripts and plugins to the core app.

closes #3122

Adding in Search all and Create all buttons to tagger view.
@WithoutPants
Copy link
Collaborator

This plugin way of finding and clicking buttons via the DOM isn't an appropriate approach in the core React UI. The correct approach is likely going to involve lifting the selected result states out of SceneSearchResults and into TaggerContext, which will also be responsible for handling the save all and search all operations.

This won't be a trivial change unfortunately.

@Gykes
Copy link
Contributor Author

Gykes commented Aug 22, 2024

This plugin way of finding and clicking buttons via the DOM isn't an appropriate approach in the core React UI. The correct approach is likely going to involve lifting the selected result states out of SceneSearchResults and into TaggerContext, which will also be responsible for handling the save all and search all operations.

This won't be a trivial change unfortunately.

I figured as much which is why I had you take a look before I went further.

I have no idea how to implement it the way you are wanting but I'm all for giving it a shot.

@WithoutPants
Copy link
Collaborator

I've made a start for prototyping purposes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Create All/New/Missing on Tagger page
2 participants