Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WowNetworkVenus #1384

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

WillyOrtrun
Copy link
Contributor

@WillyOrtrun WillyOrtrun commented Jul 9, 2023

  • added filename schema parsing for files downloaded via the normal download buttons (still works with filenames, that do not fit the schema)
  • results sorted by similarity taking performers into account if they could be determined from the filename, instead of the useless default sorting of the scraped search results
  • fix no result issue, if there is a number in the scene name (removes numbers from search scraping request)
  • added sceneByFragment/Scene Identify capabilities

It is unlikely, that I will find the time to implement changes the maintaners may want, It works for my usecases so basically I am leaving this here for anyone that wants to use it, or for anybody that has the time to upstream it. I may miss notifications, as this is obvsiously a throwaway account.

Potential Improvements (listing this here in case somebody else takes over):

  • Bring into naming conventions (artists -> performers)
  • Change param[1] naming, currently in line with torrent.py, but quite confusing
  • Get rid of interleave_results(), the sorting makes this unnecessary, but still calling the function
  • Check if the new sys.argv[1] logic covers all usecases of the previous if NAME / if URL logic
  • remove debug log messages (?)

added filename schema parsing; results sorted by similarity taking performers into account; fix no result issue, if number in scene name; added sceneByFragment capabilities
param[1] naming in line with torrent.yml (likely changing that later)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant