test(starknet_client): add tests for a 0.13.2 block

[ShahakShama]

• fix: put none in commitments if they come from a deprecated formula
• test(starknet_client): add tests for a 0.13.2 block

---

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.41%. Comparing base (f5265b6) to head (9ff8a6a).
Report is 58 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
+ Coverage   65.97%   66.41%   +0.44%     
==========================================
  Files         136      139       +3     
  Lines       18128    18379     +251     
  Branches    18128    18379     +251     
==========================================
+ Hits        11960    12207     +247     
  Misses       4876     4876              
- Partials     1292     1296       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matan-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dan-starkware and @ShahakShama)

---

crates/starknet_client/resources/reader/block_post_0_13_2.json line 1 at r1 (raw file):

{

IDK how to review this file, so I'm relying on your test making use of it and that's it...

Code quote:

{

---

crates/starknet_client/src/reader/objects/block_test.rs line 159 at r1 (raw file):

    );

    // TODO(shahak): Find a block with at least 2 transactions, and uncomment the code below.

What is the blocker for this? Why not do it now?

Code quote:

    // TODO(shahak): Find a block with at least 2 transactions, and uncomment the code below.

The base branch was changed.

[ShahakShama]

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @dan-starkware and @matan-starkware)

---

crates/starknet_client/src/reader/objects/block_test.rs line 159 at r1 (raw file):

Previously, matan-starkware wrote…

What is the blocker for this? Why not do it now?

Done

[matan-starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @ShahakShama)

---

crates/starknet_client/src/reader/objects/block_test.rs line 175 at r3 (raw file):

            }
        )
    );

It looks like you don't care about any of the fields, so why not remove this clutter?

(for the entire test)

Suggestion:

    assert_matches!(
        err,
        ReaderClientError::TransactionReceiptsError(
_        )
    );

[ShahakShama]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @matan-starkware)

---

crates/starknet_client/src/reader/objects/block_test.rs line 175 at r3 (raw file):

Previously, matan-starkware wrote…

It looks like you don't care about any of the fields, so why not remove this clutter?

(for the entire test)

Done.

[matan-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-starkware and @ShahakShama)

---

crates/starknet_client/src/reader/objects/block_test.rs line 175 at r3 (raw file):

Previously, ShahakShama wrote…

Done.

I left comments on the other places "(for the entire test)"

---

crates/starknet_client/src/reader/objects/block_test.rs line 126 at r4 (raw file):

                num_of_receipts: _,
            }
        )

Suggestion:

        ReaderClientError::TransactionReceiptsError(
_
        )

---

crates/starknet_client/src/reader/objects/block_test.rs line 141 at r4 (raw file):

                receipt_tx_index: _,
            }
        )

Suggestion:

        ReaderClientError::TransactionReceiptsError(
_
        )

---

crates/starknet_client/src/reader/objects/block_test.rs line 156 at r4 (raw file):

                receipt_tx_hash: _,
            }
        )

Suggestion:

        ReaderClientError::TransactionReceiptsError(
_
        )

[ShahakShama]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-starkware and @matan-starkware)

---

crates/starknet_client/src/reader/objects/block_test.rs line 126 at r4 (raw file):

                num_of_receipts: _,
            }
        )

Done.

---

crates/starknet_client/src/reader/objects/block_test.rs line 141 at r4 (raw file):

                receipt_tx_index: _,
            }
        )

Done.

---

crates/starknet_client/src/reader/objects/block_test.rs line 156 at r4 (raw file):

                receipt_tx_hash: _,
            }
        )

Done.