Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): dont check fin in network manager #2114

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Jun 16, 2024

This change is Reviewable

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.42%. Comparing base (25c2370) to head (a72d671).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/papyrus_network/src/network_manager/mod.rs 66.66% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
+ Coverage   68.40%   68.42%   +0.02%     
==========================================
  Files         132      132              
  Lines       17602    17602              
  Branches    17602    17602              
==========================================
+ Hits        12041    12045       +4     
+ Misses       4226     4223       -3     
+ Partials     1335     1334       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

asmaastarkware
asmaastarkware previously approved these changes Jun 17, 2024
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@ShahakShama ShahakShama added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 22a338d Jun 18, 2024
19 checks passed
@ShahakShama ShahakShama deleted the shahak/remove_fin_check_NM branch June 18, 2024 04:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants