-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update clippy errors for 06.16.2024 #2110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware and @DvirYo-starkware)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
==========================================
+ Coverage 68.06% 68.29% +0.22%
==========================================
Files 132 132
Lines 17665 17585 -80
Branches 17665 17585 -80
==========================================
- Hits 12024 12009 -15
+ Misses 4311 4244 -67
- Partials 1330 1332 +2 ☔ View full report in Codecov by Sentry. |
c68e65b
to
4082ed4
Compare
Why do you delete this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @dan-starkware, @DvirYo-starkware, and @yair-starkware)
crates/papyrus_network/src/db_executor/mod.rs
line 263 at r2 (raw file):
Previously, yair-starkware (Yair) wrote…
Why do you delete this?
We need to remove this regardless (We forgot erasing when we added something else instead)
Clippy said there's an error here so I've decided to delete this instead of fixing the error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware and @DvirYo-starkware)
This change is