Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update clippy errors for 06.16.2024 #2110

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Jun 16, 2024

This change is Reviewable

yair-starkware
yair-starkware previously approved these changes Jun 16, 2024
Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware and @DvirYo-starkware)

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (14ee3bb) to head (4082ed4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2110      +/-   ##
==========================================
+ Coverage   68.06%   68.29%   +0.22%     
==========================================
  Files         132      132              
  Lines       17665    17585      -80     
  Branches    17665    17585      -80     
==========================================
- Hits        12024    12009      -15     
+ Misses       4311     4244      -67     
- Partials     1330     1332       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yair-starkware
Copy link
Contributor

crates/papyrus_network/src/db_executor/mod.rs line 263 at r2 (raw file):

// A wrapper struct for Vec<StateDiffsResponse> so that we can implement traits for it.
pub struct StateDiffsResponseVec(pub Vec<protobuf::StateDiffsResponse>);

Why do you delete this?

Copy link
Contributor Author

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @dan-starkware, @DvirYo-starkware, and @yair-starkware)


crates/papyrus_network/src/db_executor/mod.rs line 263 at r2 (raw file):

Previously, yair-starkware (Yair) wrote…

Why do you delete this?

We need to remove this regardless (We forgot erasing when we added something else instead)
Clippy said there's an error here so I've decided to delete this instead of fixing the error

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware and @DvirYo-starkware)

@ShahakShama ShahakShama added this pull request to the merge queue Jun 16, 2024
Merged via the queue into main with commit a3d53c4 Jun 16, 2024
19 checks passed
@ShahakShama ShahakShama deleted the shahak/clippy-06-16-2024 branch June 16, 2024 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants