-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus): add run_consensus #2108
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2108 +/- ##
==========================================
- Coverage 68.35% 68.34% -0.01%
==========================================
Files 132 132
Lines 17585 17585
Branches 17585 17585
==========================================
- Hits 12020 12019 -1
Misses 4234 4234
- Partials 1331 1332 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)
crates/sequencing/papyrus_consensus/src/lib.rs
line 43 at r1 (raw file):
.expect("Failed to receive a message from network") .expect("Network receiver closed unexpectedly"); let (proposal_init, content_receiver, fin_receiver) = proposal.into();
Since we don't fill content_receiver
anywhere else, this means that into
pre-fills the receiver will all of the transactions, right? (I think this is fine for now since this is a fake flow anyways)
Code quote:
let (proposal_init, content_receiver, fin_receiver) = proposal.into();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware)
crates/sequencing/papyrus_consensus/src/lib.rs
line 43 at r1 (raw file):
Previously, matan-starkware wrote…
Since we don't fill
content_receiver
anywhere else, this means thatinto
pre-fills the receiver will all of the transactions, right? (I think this is fine for now since this is a fake flow anyways)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @matan-starkware)
crates/sequencing/papyrus_consensus/src/lib.rs
line 43 at r1 (raw file):
Previously, DvirYo-starkware wrote…
Done.
true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)
This change is