Meta SNIP for security council actions (part of the meta snip on security) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eikix
reviewed
Jul 17, 2024
Eikix
reviewed
Jul 17, 2024
Eikix
reviewed
Jul 17, 2024
Eikix
reviewed
Jul 17, 2024
lucadonnoh
reviewed
Jul 17, 2024
SNIPS/snip-template copy.md
Outdated
|
|
||
| - an L1 multisig | ||
| - Add a timelock to Starknet core contracts on L1 + the ability for the security council's multisig to bypass it (for phase 1) | ||
| - Add a pausable function only callable by the security council's multisig (for phase 2) |
There was a problem hiding this comment.
this approach doesn't fully make sense. Pausing should be an immediate action and going through a SC takes too long. A better approach is: give the pause button to a centralized entity, i.e. starkware foundation, and have the SC have the ability to unpause and revoke such permission if the foundation misbehaves. This is how it is implemented in OP Mainnet. It makes sense to do so since pausing is a reversible action
|
Changing this SNIP to become all actions encompassed by the Security Council |
Eikix
changed the title
|
Closing this PR in favor of #93 since we merged all Security Council SNIPs into one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafting the meta SNIP for Security Council as part of the Fête du SNIP
Part of Elias'PR