Generalize the worker pool implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* delayed_job_worker_pool is a great worker pool implementation, that's in many already pretty generalized * With some tweaks, it could be an awesome general worker pool usable for any task. * This initial work primarily switches to a more generic bin name, and allows you to hand in a so that it can start any worker code you have built, vs only being able to start the delayed job worker code * There are lots more generalizations to be made, but this is a first step that already makes it usable for other tasks (you still have to handle signals in your code, since those get deregistered in the forks, but that's ok for now)
* Kludgy - the idea is wanting to know if you have a set of 4 workers, which part of the set failed so when you re-fork a new worker it can take over the work that was previously being acted on in the failed process
* Fix immediately broken spec (some other specs still fail currently because we no longer include delayed job active record)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delayed_job_worker_pool is a great worker pool implementation, that's in many ways already pretty generalized
With some tweaks, it could be an awesome general worker pool usable for any task.
This initial work primarily switches to a more generic bin name, and allows you to hand in a
worker_factoryso that it can start any worker code you have built, vs only being able to start the delayed job worker codeThere are lots more generalizations to be made, but this is a first step that already makes it usable for other tasks (you still have to handle signals in your code, since those get deregistered in the forks, but that's ok for now)