Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r_eff default to NULL #369

Merged
merged 3 commits into from
May 14, 2024
Merged

r_eff default to NULL #369

merged 3 commits into from
May 14, 2024

Conversation

n-kall
Copy link
Collaborator

@n-kall n-kall commented May 14, 2024

Summary

Sets r_eff back to NULL as default for pareto_smooth. At a later time, this may be changed, but now this fixes the inconsistency.

Fixes #368

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@paul-buerkner
Copy link
Collaborator

Looks good. For these minor PRs feel free to merge them directly unless you have something that you want me to check.

@n-kall
Copy link
Collaborator Author

n-kall commented May 14, 2024

Great, but I don't have merge permissions for this repo

@paul-buerkner
Copy link
Collaborator

Fair point. I will merge it then.

@paul-buerkner paul-buerkner merged commit 419a1a3 into stan-dev:master May 14, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default for r_eff in pareto_smooth() and pareto_khat() differ
2 participants