Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to log weight smoothing #332

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

n-kall
Copy link
Collaborator

@n-kall n-kall commented Jan 9, 2024

Summary

This fixes an issue in pareto smoothing log weights as the are_log_weights argument was not properly passed through

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@paul-buerkner paul-buerkner merged commit 1210f4a into stan-dev:master Jan 9, 2024
2 of 10 checks passed
@paul-buerkner
Copy link
Collaborator

thanks!

Copy link

github-actions bot commented Jan 9, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a9e3d16 is merged into master:

  •   :ballot_box_with_check:as_draws_array: 101ms -> 101ms [-0.49%, +1.21%]
  •   :ballot_box_with_check:as_draws_df: 32ms -> 31.9ms [-1.98%, +1.33%]
  • ❗🐌as_draws_list: 187ms -> 191ms [+0.12%, +4.14%]
  •   :rocket:as_draws_matrix: 30.8ms -> 29.9ms [-5.02%, -1.01%]
  •   :ballot_box_with_check:as_draws_rvars: 158ms -> 158ms [-0.84%, +1.41%]
  •   :ballot_box_with_check:summarise_draws_100_variables: 715ms -> 713ms [-0.61%, +0.06%]
  •   :ballot_box_with_check:summarise_draws_10_variables: 79.1ms -> 79ms [-0.54%, +0.38%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants