Add sentinel1.grd subpackage #11
Conversation
This seems to have changed in a recent release. Also pin to a minor version, although it seems like 2.3.* has been out for a while so they are potentially not following semver, and this may not have avoided the current issue.
Also avoid using un-imported subpackages of pystac by accessing core types directly from the top level package.
Also add the exampel item.json from sentinel1-grd
|
@maximlamare invited you to this repository; I can't assign you as a reviewer until that invite is accepted, but would like you to please review! |
|
thanks @lossyrob! I'm going to try a release of the current code on pypi since we never did that, then we can add this PR to the CHANGELOG and make a new release |
| # Fixed properties | ||
| sar_ext.frequency_band = FrequencyBand("C") | ||
| sar_ext.center_frequency = 5.405 |
There was a problem hiding this comment.
in the future would be good to consolidate common properties for GRD,RTC,SLC, etc under sentinel1/properties.py
| root = XmlElement.from_file(self.href) | ||
| data_object_section = root.find("dataObjectSection") | ||
| if data_object_section is None: | ||
| raise ManifestError( | ||
| f"Manifest at {self.href} does not have a dataObjectSection") |
There was a problem hiding this comment.
@maximlamare just wanted to point out https://github.com/bopen/xarray-sentinel/blob/main/xarray_sentinel/esa_safe.py , which seems to be a nice approach for parsing SAFE files using the accompanying .xsd files for XML validation and parsing
There was a problem hiding this comment.
Once we have contributed all sensors we had in mind, I could take a look and propose an update to account for this.
Related Issue(s):
stactools-packages/sentinel1-grd#2
Description:
This PR moves the code for processing Sentinel1 GRD that currently exists in https://github.com/stactools-packages/sentinel1-grd into a subpackage of this project.
The project is refactored to include two subpackages -
rtcandgrd. The existing code is moved into thertcsubpackage and the code from sentinel1-grd is moved to thegrdsubpackage. The top-levelstac sentinel1command is now a group that hasrtcandgrdas subcommands, which behave how the previousstac sentinel1andstac sentinel1grdcommands worked, respectively.I've updated the README to account for these two datasets along with the examples and tests.
NOTE: The GRD code was created by @maximlamare, all credit to them - I'm just moving it over. @maximlamare if you'd like to rebase these commits and force push to this branch so that your account is associate with the commits by all means do so!
PR checklist:
scripts/format).scripts/lint).scripts/test).