Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Push #2

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Initial Push #2

wants to merge 8 commits into from

Conversation

tomer-rockman
Copy link

@tomer-rockman tomer-rockman commented Aug 26, 2021 •
edited
Loading

Before you submit a pull request, please fill in the following:

Related Issue(s):
Please add links (if any) to related github issues.

Description:
First PR for NOAA-SST Data.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@tomer-rockman tomer-rockman marked this pull request as ready for review August 31, 2021 23:26
@tomer-rockman tomer-rockman reopened this Sep 2, 2021
darrenwiens
darrenwiens suggested changes Sep 10, 2021
View reviewed changes
Copy link

@darrenwiens darrenwiens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, definitely on the right track. Just a few small things.

src/stactools/noaa_sst/commands.py Show resolved Hide resolved
src/stactools/noaa_sst/commands.py Show resolved Hide resolved
src/stactools/noaa_sst/constants.py Outdated Show resolved Hide resolved
src/stactools/noaa_sst/constants.py Outdated Show resolved Hide resolved
src/stactools/noaa_sst/stac.py Outdated Show resolved Hide resolved
src/stactools/noaa_sst/stac.py Show resolved Hide resolved
src/stactools/noaa_sst/constants.py Outdated Show resolved Hide resolved
src/stactools/noaa_sst/stac.py Show resolved Hide resolved
@cuttlefish cuttlefish self-requested a review September 11, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenwiens darrenwiens darrenwiens requested changes

@cuttlefish cuttlefish Awaiting requested review from cuttlefish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomer-rockman @darrenwiens