Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step-geometry #11

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Step-geometry #11

merged 7 commits into from
Aug 30, 2023

Conversation

constantinius
Copy link
Collaborator

Fixing rounding errors when calculating dimension step size
Fixing calculating geometry, by adjusting for "pixel is area"

gadomski
gadomski reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this includes the diff from #10, so I'm going to mark this as draft until that one's merged.

@gadomski gadomski marked this pull request as draft August 28, 2023 12:51
@constantinius constantinius marked this pull request as ready for review August 28, 2023 13:55
gadomski
gadomski reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any simple test case we can add for this one? I think I understand what's going on, but a test could help future me/someone know what the expected behavior should be.

@constantinius
Copy link
Collaborator Author

I will try to come up with some tests

@gadomski
Copy link
Collaborator

LGTM but needs lints fixed.

@gadomski gadomski enabled auto-merge (squash) August 30, 2023 14:22
@gadomski gadomski merged commit 9cf1fce into main Aug 30, 2023
4 checks passed
@gadomski gadomski deleted the step-geometry branch August 30, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@constantinius @gadomski