feat: set up prettier #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradel
reviewed
Feb 25, 2022
package.json
Outdated
| "scripts": { | ||
| "start": "npm run build && node lib/index.js", | ||
| "start:regtest": "BSK_SUBDOMAIN_CONFIG=config-develop.json BSK_SUBDOMAIN_REGTEST=true npm run start", | ||
| "build": "babel src -d lib", | ||
| "flow": "flow", | ||
| "lint": "eslint src", | ||
| "lint:fix": "eslint src --fix", | ||
| "lint": "eslint src && npm run lint:prettier", |
There was a problem hiding this comment.
maybe let's move eslint to a separate script lint:eslint https://github.com/hirosystems/stacks-blockchain-api/blob/master/package.json#L30?
| import { PAYER_SK, OWNER_SK, DEVELOP_DOMAIN, ADMIN_PASSWORD } from './developmode' | ||
| import winston from 'winston' | ||
| import fs from 'fs' | ||
| import { PAYER_SK, OWNER_SK, DEVELOP_DOMAIN, ADMIN_PASSWORD } from './developmode'; |
There was a problem hiding this comment.
looks like prettier is somehow creating issues with the current eslint config, might be a good idea to use the npm package https://github.com/hirosystems/eslint-config for eslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue briefly discussed : #77
This is part of M1 of : Subdomain registrar improvement stacksgov/grants-program#282
Type of change
Config update | code formatting improvement
Does this introduce a breaking change?
No breaking change!