Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use bootstrap signing set when missing rotate keys tx #655

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: use bootstrap signing set when missing rotate keys tx #655

wants to merge 14 commits into from

Conversation

djordon
Copy link
Contributor

@djordon djordon commented Oct 11, 2024 •
edited
Loading

Description

Closes #652.

Changes

  • Add a column into the dkg_shares with the signing set information.
  • Fallback to the last known DKG aggregate key if there are no key rotation transactions. Edit: I'm actually a little nervous about using the DKG keys by timestamp, since this isn't guaranteed to be consistent across signers. Might be best to tie it to the bitcoin block that it was done over. Created [Feature]: Use the bitcoin block hash instead of a timestamp for getting the "last" DKG shares #661 for this.
  • Fallback to the bootstrap signing set if there are no key rotation transactions.

Testing Information

This still needs an integration test for the query and another integration test for the fallback behaviors.

Checklist:

  • I have performed a self-review of my code

@djordon djordon added sbtc bootstrap signer The sBTC Bootstrap Signer. key rotation The functionality to rotate a private key for a signer in sBTC-v1. and removed key rotation The functionality to rotate a private key for a signer in sBTC-v1. labels Oct 11, 2024
@djordon djordon added this to the Minimum Working Deposit Flow milestone Oct 11, 2024
@djordon djordon marked this pull request as ready for review October 11, 2024 15:31
Base automatically changed from 651-store-bootstrap-signing-set-info-in-the-config to main October 11, 2024 18:24
@djordon
When fetching the current signing set
602654f 
in the TxSignerEventLoop, fall back to
the bootstrap signers if no rotate-keys tx exists
@djordon
Add a new column to the dkg_shares table
cbfdbf5
@djordon
Add a new query for fetching the last DKG
9747f8f 
output. Use it as a fallback when getting the
signer set when signing bitcoin transactions
@djordon
Use the signer set from the column
3ad3147 
when loading WSTS state machines from
the database
@djordon
Make sure the signer set in the test matches
43ffa8c
@djordon
Add a proper in memory implementation
78ad432 
of the get_last_dkg_shares function
@djordon
Update the comments on the function
8716621 
and make it public for testing purposes.
@djordon
Add integration test for fall back behavior
4ae33a4
@djordon
Add integration test for query
1a476c8
@djordon djordon force-pushed the 652-use-fallback-keys-when-missing-rotate-keys-tx branch from cee7b34 to 1a476c8 Compare October 11, 2024 18:25
This was referenced Oct 11, 2024
Open
Closed
@djordon djordon changed the title feat: use fallback keys when missing rotate keys tx feat: use bootstrap signing set when missing rotate keys tx Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiloc Jiloc Awaiting requested review from Jiloc

@matteojug matteojug Awaiting requested review from matteojug

@AshtonStephens AshtonStephens Awaiting requested review from AshtonStephens

@cylewitruk cylewitruk Awaiting requested review from cylewitruk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.
Projects
sBTC
Status: In Progress
Milestone
Minimum Working Deposit Flow
Development

Successfully merging this pull request may close these issues.

[Feature]: Use bootstrap keys when missing rotate-keys transactions
1 participant
@djordon