feat: sign and broadcast Stacks transactions #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there a separate ticket for this? |
No not yet. There are a few TODOs in this PR that I need to turn into outstanding tickets, this was just one of them. |
djordon
changed the title
complete-deposit transactions
djordon
force-pushed
the
563-create-complete-deposit-transactions
branch
from
40100f8
to
70da07f
Compare
djordon
force-pushed
the
320-tx-coordinator-sign-stacks-response-transactions
branch
from
1facab7
to
e75104f
Compare
|
Created ticket to track the lack of integration tests here: #630 |
matteojug
reviewed
Oct 8, 2024
Base automatically changed from
563-create-complete-deposit-transactions
to
main
October 9, 2024 13:52
transaction sign request object
TxSignerEventLoop
you are the only signer
djordon
force-pushed
the
320-tx-coordinator-sign-stacks-response-transactions
branch
from
386bc86
to
c07d85c
Compare
better logging
matteojug
approved these changes
Oct 9, 2024
cylewitruk
approved these changes
Oct 9, 2024
| Bitcoin: BitcoinInteract + Clone + Send + Sync, | ||
| Stacks: StacksInteract + Clone + Send + Sync, | ||
| Emily: EmilyInteract + Clone + Send + Sync, | ||
| Storage: DbRead + DbWrite + Clone + Sync + Send + 'static, |
There was a problem hiding this comment.
What was it that made these all need to be 'static?
|
@djordon can you lay out the test plan so that @matteojug can take it? |
…gn-stacks-response-transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #616.
Note that we purposefully skip validation for now, but it should be relatively straightforward to hook up.
Changes
&'static, which they all are. This was needed for borrow checker.StacksTransactionSignRequest. We can probably remove the digest from that type, we will do that later.This PR needs some polish and some tests.
Testing Information
The main test that is needed is that the transaction coordinator broadcasts a signed
complete-deposittransaction for a deposit request with a sweep transaction on bitcoin.Checklist: