Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add emily to context #608

Merged
merged 1 commit into from
Oct 3, 2024
Merged

feat: add emily to context #608

merged 1 commit into from
Oct 3, 2024

Conversation

matteojug
Copy link
Collaborator

@matteojug matteojug commented Oct 3, 2024 •
edited
Loading

Description

Add Emily client to context

Changes

Usual boilerplate, based on #606

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

cylewitruk
cylewitruk approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Hopefully we're just about done adding these central deps to the context :)

signer/src/testing/transaction_coordinator.rs Show resolved Hide resolved
@matteojug matteojug merged commit 3b73797 into main Oct 3, 2024
4 checks passed
@matteojug matteojug deleted the feat/emily-in-context branch October 3, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cylewitruk cylewitruk cylewitruk approved these changes

@djordon djordon Awaiting requested review from djordon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteojug @cylewitruk