feat: broadcast withdrawal decision + tests #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cylewitruk
commented
Oct 3, 2024
| .await; | ||
|
|
||
| let msg = message::SignerWithdrawalDecision { | ||
| request_id: withdrawal_request.request_id, | ||
| block_hash: withdrawal_request.block_hash.0, |
There was a problem hiding this comment.
Plz double-check that this message is (1) correct, (2) populated with the correct data
matteojug
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The transaction signer wasn't broadcasting its withdrawal decision in
handle_pending_withdraw_request(); this PR adds it and adjusts both the deposit + withdrawal tests to verify that it's broadcasted.Changes
SignerWithdrawalDecisioninhandle_pending_withdrawal_request().withdrawtowithdrawalTesting Information
Nothing special other than what's noted above.
Checklist: