Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: db stacks transactions validated incorrectly #599

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

djordon
Copy link
Contributor

@djordon djordon commented Oct 1, 2024

Description

Closes #523.

Changes

  • This change makes sure that we only extract stacks transactions that were deployed by the appropriate entity.

Testing Information

There was a test for extracting relevant stacks transactions and it was updated to check that contract calls to smart contracts with the incorrect stacks addresses are ignored.

Checklist:

  • I have performed a self-review of my code

@djordon djordon added the sbtc bootstrap signer The sBTC Bootstrap Signer. label Oct 1, 2024
@djordon djordon added this to the sBTC Release Ready milestone Oct 1, 2024
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

signer/src/stacks/wallet.rs Outdated Show resolved Hide resolved
signer/tests/integration/postgres.rs Show resolved Hide resolved
@djordon djordon force-pushed the 523-db-stacks-transactions-validated-incorrectly branch from f63ba4f to 1e91566 Compare October 2, 2024 16:15
@djordon djordon merged commit 2ceecef into main Oct 2, 2024
7 checks passed
@djordon djordon deleted the 523-db-stacks-transactions-validated-incorrectly branch October 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Postgres stacks transactions are not validated correctly
2 participants