Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move stacks client into signer context #598

Merged
merged 2 commits into from
Oct 2, 2024
Merged

feat: move stacks client into signer context #598

merged 2 commits into from
Oct 2, 2024

Conversation

djordon
Copy link
Contributor

@djordon djordon commented Oct 1, 2024

Description

Closes #597.

Changes

  • Move the stacks client into the signer context
  • Make sure the async trait functions implement Send

Testing Information

Moreover nothing uses the new context for the stacks client so all tests should pass.

Checklist:

  • I have performed a self-review of my code

@djordon djordon added the sbtc bootstrap signer The sBTC Bootstrap Signer. label Oct 1, 2024
@djordon djordon added this to the Minimum Working Deposit Flow milestone Oct 1, 2024
cylewitruk
cylewitruk approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- note I've got some changes incoming for the TestContext (including a builder), so that will be much easier to use (and flexible) moving forward.

@djordon djordon merged commit a6f201c into main Oct 2, 2024
4 checks passed
@djordon djordon deleted the 597-move-stacks-client-into-signer-context branch October 2, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cylewitruk cylewitruk cylewitruk approved these changes

@matteojug matteojug Awaiting requested review from matteojug

@AshtonStephens AshtonStephens Awaiting requested review from AshtonStephens

Assignees
No one assigned
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.
Projects
sBTC
Status: Done
Milestone
Minimum Working Deposit Flow
Development

Successfully merging this pull request may close these issues.

[Feature]: Move Stacks client into signer context
2 participants
@djordon @cylewitruk