Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more protobuf types part 2 #577

Merged
merged 6 commits into from
Sep 26, 2024
Merged

feat: add more protobuf types part 2 #577

merged 6 commits into from
Sep 26, 2024

Conversation

djordon
Copy link
Contributor

@djordon djordon commented Sep 26, 2024

Description

This PR pushes #412 further along and a follow-up to #558.

The documentation was taken from the existing structs.

Changes

  • Add over a some transaction message types.
  • Add a recoverable signature message type.
  • Split things up into different files.

Testing Information

There protobufs aren't used, so there are no tests at the moment.

Checklist:

  • I have performed a self-review of my code

@djordon djordon added sbtc bootstrap signer The sBTC Bootstrap Signer. signer communication Communication across sBTC bootstrap signers. labels Sep 26, 2024
cylewitruk
cylewitruk reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, since these aren't used (yet) I'm guessing that these will be iterated upon later. Just had one comment re: the bitcoin types.

protobufs/stacks/common.proto Outdated Show resolved Hide resolved
cylewitruk
cylewitruk approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@djordon djordon merged commit 9c55459 into main Sep 26, 2024
4 checks passed
@djordon djordon deleted the 412-part2-protobuf-signer-communication branch September 26, 2024 14:35
@djordon djordon mentioned this pull request Sep 27, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cylewitruk cylewitruk cylewitruk approved these changes

@matteojug matteojug Awaiting requested review from matteojug

@AshtonStephens AshtonStephens Awaiting requested review from AshtonStephens

Assignees
No one assigned
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer. signer communication Communication across sBTC bootstrap signers.
Projects
sBTC
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djordon @cylewitruk