Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add required pnpm version to prevent lockfile changes #135

Merged
merged 1 commit into from
May 8, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented May 8, 2024

This PR adds a required PNPM version to the root-level package.json. This will prevent devs using different versions of PNPM, which will cause unnecessary changes to the lockfile.

This also changes the version of ESLint used by the contracts package to prevent the "incorrect peer dependency" issue.

@AshtonStephens
Copy link
Collaborator

Fixing my local pnpm to match

Copy link
Collaborator

@AshtonStephens AshtonStephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@hstove hstove merged commit d51595b into main May 8, 2024
3 checks passed
@hstove hstove deleted the fix/pnpm-version branch May 8, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants