Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Signer message signing and validation #129

Merged
merged 5 commits into from
May 8, 2024

Conversation

netrome
Copy link
Contributor

@netrome netrome commented May 7, 2024

closes #105

Description

This PR introduces signing and validation logic for signer messages. As part of this change, the signer_public_key and signature fields of the SignerMessage type has been moved to the new Signed wrapper type to allow for ergonomic handling of signatures.

@netrome netrome self-assigned this May 7, 2024
@netrome netrome linked an issue May 7, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a small style nit and a question, but it looks good.

signer/src/ecdsa.rs Outdated Show resolved Hide resolved
signer/src/ecdsa.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@AshtonStephens AshtonStephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@netrome netrome force-pushed the 105-feature-message-signing-and-validation branch from 870adc0 to e261bff Compare May 8, 2024 09:42
@netrome netrome merged commit 04dc6ea into main May 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Message signing and validation
4 participants