Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Sign and submit complete-deposit transactions #616

Open
1 task
djordon opened this issue Oct 4, 2024 · 0 comments · May be fixed by #617
Open
1 task

[Feature]: Sign and submit complete-deposit transactions #616

djordon opened this issue Oct 4, 2024 · 0 comments · May be fixed by #617
Assignees
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Contributor

djordon commented Oct 4, 2024

Feature - Sign and submit complete-deposit transactions

1. Description

This is part of #320, but focused on complete-deposit transactions.

After we have a stacks transactions that needs signing, we need to get it signed and broadcasted.

1.1 Context & Purpose

We need to make sure that the coordinator asks the other signers to sign the transaction, add them to the transaction and the broadcast them.

2. Technical Details:

We need to hook up the TxSignerEventLoop to listen for the right messages and sign them if they are valid. For this ticket, we do not worry too much about making sure that they are valid, just that we sign them.

2.1 Acceptance Criteria:

  • We can finish a full loop where we sign and broadcast complete-deposit stacks transactions that have response transactions on bitcoin.

3. Related Issues and Pull Requests (optional):

This is part of #320, and builds off of #563.

@djordon djordon added the sbtc bootstrap signer The sBTC Bootstrap Signer. label Oct 4, 2024
@djordon djordon added this to the Minimum Working Deposit Flow milestone Oct 4, 2024
@djordon djordon self-assigned this Oct 4, 2024
@djordon djordon linked a pull request Oct 4, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc bootstrap signer The sBTC Bootstrap Signer.
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

3 participants
@matteojug @djordon and others