This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
Python3 compatibility #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this is awesome! Thank you for taking the time to send us a PR! I'll run it through our integration tests today :) |
|
Great work and thank you @DonnchaC, appreciate the PR. |
|
All tests are now run automatically by Tox in Python 2.7, Python 3.4 and Python 3.5 environments. Sorry about the noisy commits as I was trying to get CircleCI to support other Python versions. |
|
Any word on this branch getting merged? |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this library. This PR fixes some issues I noticed when trying to use the library under Python 3. With these changes the unittests now all pass under Python 2 and Python 3. I have not tested the rest of the codebase, there may still be issues in areas without unit test coverage.
You should consider using
toxto run your unit tests automatically in Python 2 and Python 3 environments.As an aside will you be keeping this library up to date on PyPi? It's a little confusing that the package name in this repo doesn't match the published package.