Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Add appsMeta with pubKey to profile (for storageConnected apps) #2000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

friedger
Copy link
Contributor

@friedger friedger commented Dec 8, 2019

This PR

  • add appsMeta to the user profile (next to apps) that contains
    • the public key for the user for the app (public_key) and
    • the gaia hub url as in apps (storage)

Required for hirosystems/stacks.js#458

The profile looks
Screenshot from 2019-12-09 08-57-34

@hstove
Copy link
Collaborator

hstove commented Dec 9, 2019

Thanks, Friedger! I like that the benefit of this is pretty high, given not too much complexity. One thing I'll add is that we definitely need tests before merging this in. We already have tests around the publish_data scope, so you can probably follow those patterns to test this.

I'll bring this up in our next meeting around the user experience team.

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants