Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #407, where I missed two aspects:
The LBM user-data must be adapted to pass double-dash flags to yawollet.
Note that double-dash flags also work for
flag
. Hence, rolling out this version of yawol-controller (specifying double-dashes in user-data) but keeping the old yawollet image (usingpflag
) will still work but not vice-versa.Also, controller-runtime registers the
--kubeconfig
flag in the defaultflag.CommandLine
. Hence, we must bring it back by explicitly registering it in thepflag.FlagSet
.